Migrate PathDisplay #236
Merged
Migrate PathDisplay #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ordering of scene nodes is not deterministic => use container matchers
- matchers for ASSERT_THAT can easily be reused - ASSERT_THAT style assertions are better to read
- EqVector3 -> Vector3Eq and EqQuaternion -> QuaternionEq
|
CI:
|
wjwwood
approved these changes
Mar 31, 2018
rviz_default_plugins/CMakeLists.txt
Outdated
| @@ -118,6 +121,7 @@ target_link_libraries(rviz_default_plugins | |||
| ) | |||
| ament_target_dependencies(rviz_default_plugins | |||
| # geometry_msgs | |||
There was a problem hiding this comment.
This one should probably also be uncommented?
rviz_default_plugins/package.xml
Outdated
| @@ -29,6 +29,8 @@ | |||
| <depend>rviz_common</depend> | |||
| <depend>rviz_rendering</depend> | |||
| <depend>urdf</depend> | |||
| <depend>geometry_msgs</depend> | |||
| <depend>nav_msgs</depend> | |||
There was a problem hiding this comment.
nitpick: please alphabetically order dependencies :)
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
|
|
There was a problem hiding this comment.
nitpick: minimize vertical whitespace
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81.