Migrate select tool #256
Merged
Migrate select tool #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
|
Try to fix error on Windows (we can't reproduce for whatever reason):
The new CMake warning on Linux should be unrelated. |
|
New CI after we added some small refactorings:
This windows test failure is not related to rviz. |
- Push necessary functionality to DisplayContext - Not many more methods needed to extract VisualizationManager dependency - This allows unittesting of selection_manager
- Add a second constructor for testing - Delete publisher code (can't work well with tests)
- avoid overloaded functions for Ogre::Viewport in addition to those expecting a RenderWindow
- Some functions may need to be made public again once more of rviz is ported.
- introduce structs to simplify function signatures - replace typedefs with using
- extracts the object handling from SelectionManager - prerequisite for splitting the 3D picking from the SelectionManager - Add HandlerManager to DisplayContext/ VisualizationManager - Use HandlerManager from SelectionManager and for SelectionHandler
- offer a template function to create SelectionHandlers - add tests to point_cloud_selection_handler + refactoring - Fix sloppy following behaviour of the selection box for PoseDisplay and Arrow marker
- Refactor HandlerManager to no longer expose the handlers map - returns a HandlerRange instead which can be iterated over and contains directly the handlers - Use deadlock free locking variant - Add documentation
Store only weak_ptrs in mocks so that the cleanup can happen during teardown.
wjwwood
added
in review
greimela-si
force-pushed
the
feature/migrate_select_tool
branch
from
a8b7c02
to
38c7a10
Compare
|
New CI after rebase:
|
wjwwood
approved these changes
May 16, 2018
There was a problem hiding this comment.
lgtm
There were some files where the indentation of some statements looked weird, but it's not worth following up on in my opinion.
This was a large pr (whew 😅), so I tried to focus on files with a lot of back and forth deltas, and only skimmed files which were completely new or deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
This PR migrates the select tool enabling selection. In addition, it adds tests and refactoring to the selection part of RViz. The major changes include:
rviz_default_plugins