New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error for ignored qualifiers warning/error on GCC8 #261

Merged

wjwwood merged 1 commit into ros2:ros2 from mjbogusz:ros2_fix_ignored_qualifiers

May 16, 2018

Contributor

mjbogusz commented May 15, 2018

Building rviz using GCC8 results in few errors, including std::filesystem-related one discussed in ros/pluginlib#116.

This PR fixes another one - new GCC detects additional ignored qualifiers (const in this case) and -Werror makes it fail on them.


          Fix build error for ignored qualifiers warning/error on GCC8

2d7c2d0

wjwwood added enhancement in review labels

wjwwood added this to the bouncy milestone

wjwwood approved these changes

View reviewed changes

wjwwood merged commit cff3fe6 into ros2:ros2

Member

wjwwood commented May 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment