Migrate measure tool #264
Migrate measure tool #264
Conversation
|
CI:
Edit: Restarting ci jobs that failed due to ssh_agend disconnect. |
|
Next try (after adding gmock to package xml):
|
This avoids problems with protected Ogre::SharedPtr member.
- ToolTestFixture does not inherit from testing::Test so that it can be used together with DisplayTestFixture. Multiple inheritance of test fixtures does not work properly.
Change the default to have higher contrast
Martin-Idel-SI
force-pushed
the
feature/migrate_measure_tool
branch
from
7662b9a
to
f62f8fe
Compare
| */ | ||
|
|
||
| #include <gtest/gtest.h> | ||
| #include <gmock/gmock.h> |
There was a problem hiding this comment.
I think you should only include one or the other here. I don't think it will cause a problem, but I do think it's unnecessary as I think gmock include gtest for you. At some point in the past it could cause problems to include both, but I think that's been resolved at this point. Either way, consider not doing this in the future or a small follow up pr to change this instance.
There was a problem hiding this comment.
We'll make a small followup PR, because there are also some other small things I'd like to polish (e.g. the select tool test isn't included in the CMakeLists, etc.). Thanks for pointing this out to us!
| @@ -28,6 +28,7 @@ | |||
| */ | |||
|
|
|||
| #include <gtest/gtest.h> | |||
| #include <gmock/gmock.h> | |||
There was a problem hiding this comment.
And several places more in this pr, but I won't flag all of them.
Closes #212.
It also introduces a new property for the measure tool that allows to configure the color of the measurement line as the old default was barely visible in front of the default background. The default color was changed to a dark yellow. This property is visible once #251 is merged.