-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate orthographic view controller #270
Merged
wjwwood
merged 13 commits into
ros2:ros2
from
bosch-io:feature/migrate_ortho_view_controller
Jun 6, 2018
Merged
Migrate orthographic view controller #270
wjwwood
merged 13 commits into
ros2:ros2
from
bosch-io:feature/migrate_ortho_view_controller
Jun 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…position and orientation
wjwwood
approved these changes
Jun 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218
This PR includes the migration and refactoring of
FixedOrientationOrthoViewController
, with the addition of tests. It also includes some refactoring of theOrbitViewController
andViewController
classes.Furthermore, the method
FixedOrientationOrthoViewController::mimic()
has been slightly modified to obtain a consistent behaviour when switching between different view controllers.