Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault selection manager test #284

Merged
merged 3 commits into from
Jun 11, 2018
Merged

Fix segfault selection manager test #284

merged 3 commits into from
Jun 11, 2018

Conversation

anhosi
Copy link
Contributor

@anhosi anhosi commented Jun 7, 2018

Fixes #271

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jun 7, 2018
@anhosi
Copy link
Contributor Author

anhosi commented Jun 7, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit 7490ee0 into ros2:ros2 Jun 11, 2018
@rohbotics rohbotics removed the in review Waiting for review (Kanban column) label Jun 11, 2018
@greimela-si greimela-si deleted the bugfix/fix_segfault_selection_manager_test branch June 12, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anhosi @wjwwood @rohbotics @botteroa-si