Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise failed transform behaviour #292

Merged

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jun 12, 2018

The current behaviour on missing transform is pretty uneven. Some displays show something, some set a status error (or both). This PR aims to straighten out this behaviour across displays. The wanted behaviour would be:

  • Don't show anything when transform is missing
  • Show a Status error telling the user what's going on
  • With debug logging enabled, also print to the console

Two displays exhibit different behaviour as before:

  • TF display shows a warning status
  • Grid display shows the grid nevertheless. This is also necessary to not have an empty window when loading rviz without any transform.

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jun 12, 2018
@wjwwood
Copy link
Member

wjwwood commented Jun 12, 2018

Is it the case that the grid's behavior could change too when/if we fix the tf2 issue where a transform to the same frame returns an error rather than identity?

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, question about the grid's default behavior aside this is an incremental improvement, thanks!

@wjwwood wjwwood merged commit 5261bdd into ros2:ros2 Jun 12, 2018
@rohbotics rohbotics removed the in review Waiting for review (Kanban column) label Jun 12, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the feature/harmonise_failed_transform_behaviour branch June 13, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants