Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Range Display #325

Merged
merged 10 commits into from
Aug 9, 2018
Merged

Conversation

botteroa-si
Copy link
Contributor

This PR migrates the Range Display, and includes refactoring and tests.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 28, 2018
@botteroa-si
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Martin-Idel-SI
Copy link
Contributor

CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit e3baae8 into ros2:ros2 Aug 9, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Aug 9, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the feature/migrate_range_display branch August 9, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants