Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing status in laser scan display #335

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Fix missing status in laser scan display #335

merged 2 commits into from
Jul 11, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jul 11, 2018 •
edited
Loading

This is part of #332 . This will not solve the bug #332 - it will merely improve error messaging.

  • RViz should complain in the GUI when the transform of the laser scan is missing.
  • Furthermore, error messages printed to the console are improved by using the tf2 error message directly.

Note: Showing tf2 error messages in the GUI would require a heavier refactoring as the status is handled at a different level than error processing (display vs frame_manager).

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 11, 2018
@wjwwood wjwwood merged commit 09905a3 into ros2:ros2 Jul 11, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jul 11, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the bugfix/missing_status_in_laser_scan_display branch July 12, 2018 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Martin-Idel-SI @wjwwood @dirk-thomas