changes to avoid deprecated API's #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <william@osrfoundation.org>
ivanpauno
reviewed
May 7, 2019
rviz_default_plugins/src/rviz_default_plugins/displays/camera/camera_display.cpp
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/map/map_display.cpp
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/marker/marker_display.cpp
Show resolved
Hide resolved
dirk-thomas
approved these changes
May 8, 2019
| @@ -66,7 +66,7 @@ void GoalTool::updateTopic() | |||
| { | |||
| // TODO(anhosi, wjwwood): replace with abstraction for publishers once available | |||
| publisher_ = context_->getRosNodeAbstraction().lock()->get_raw_node()-> | |||
| template create_publisher<geometry_msgs::msg::PoseStamped>(topic_property_->getStdString()); | |||
| template create_publisher<geometry_msgs::msg::PoseStamped>(topic_property_->getStdString(), 10); | |||
There was a problem hiding this comment.
In these cases an explicit local variable for the numeric parameter might be more readable, like https://github.com/ros2/rosidl_python/blob/c66c3b7075a8e9c9ef01826f547d7996e0c6c604/rosidl_generator_py/resource/_msg_support.c.em#L623-L624
This certainly doesn't need to be addressed to get this merged - it is merely a thought.
ivanpauno
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#713