Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Werror #420

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Remove -Werror #420

merged 1 commit into from
Jun 27, 2019

Conversation

allenh1
Copy link
Contributor

@allenh1 allenh1 commented Jun 27, 2019

This removes -Werror from the default set of compiler flags, as @wjwwood mentioned was alright to do in this comment.

This should resolve #402.

@allenh1
Remove -Werror from defualt compiler options
0377cbb 
Signed-off-by: Hunter L. Allen <hunterlallen@protonmail.com>
@allenh1 allenh1 added the in review Waiting for review (Kanban column) label Jun 27, 2019
@allenh1 allenh1 requested a review from wjwwood June 27, 2019 18:21
@wjwwood
Copy link
Member

wjwwood commented Jun 27, 2019

CI, just in case there some unforeseen interaction with Jenkins:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood self-assigned this Jun 27, 2019
@richmattes richmattes mentioned this pull request Jun 27, 2019
Closed
@wjwwood wjwwood merged commit 8b2fcc1 into ros2 Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-werror branch June 27, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@wjwwood wjwwood

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure on Fedora 30 (using GCC9)
2 participants
@allenh1 @wjwwood