Fix wrong resource group for robot links #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Jan 15, 2020
|
CI:
|
|
All of the test failures on macOS are due to not having a screen ( I'll merge assuming that's a buildfarm issue (which I am following up on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #494
We only initialize the resource groups "rviz_rendering" and the default group, thus "rviz_common" is never initialized and throws the error. Since all meshes will be put into the "rviz_rendering" resource group if they are loaded by the mesh loader, the robot meshes should be too.
It would be great to have a test, but it needs materials and I don't have any, so I'm going to leave it as is.