Fix Image topic property not populating #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I might have misunderstood something here, but seems to me like we can use the same method of getting MessageType that is being used in MessageFilterDisplay: https://github.com/ros2/rviz/blob/cd1da34cfc01d9c6223c181ba6e7bf277ee4c1a8/rviz_common/include/rviz_common/message_filter_display.hpp#L63
|
@audrow hoping you're the right person to ping here. Not even sure a PR is the right venue for a tiny one-line change like this. I'd love to not have to always type the image topic though, and the change is already used elsewhere in rviz. Any thoughts? |
|
This looks like a good change to me - thanks, @paulerikf. I'll try it locally in the next day or so. |
audrow
approved these changes
Jun 29, 2021
|
@ahcorde mentions that the macOS warning is unrelated in another issue: #722 (comment) Does that essentially mean this is good to go? |
|
Thanks for the PR @paulerikf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might have misunderstood something here, but seems to me like we can use the same method of extracting the MessageType that is being used in MessageFilterDisplay.