Fix using plugins on Windows #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ahcorde
approved these changes
Jul 13, 2021
|
|
|
I don't think my changes are affecting the CI failures. The error I see is Any idea what might be causing it? |
|
|
I think it's a failure in the CI |
|
@ahcorde All the test failures seem to due to a certificate not being valid which isn't related to my change. Is this ready to merge? |
|
The test failures are all in CycloneDDS itself (so not related to this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when attempting to use the MoveIt2 Rviz plugins, they would all fail to load, and I would get errors like
I was able to fix these errors by exporting InteractiveMarkers