Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed TODO in test_local_parameters #545

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Addressed TODO in test_local_parameters #545

merged 1 commit into from
Apr 15, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 12, 2024

This is what you expect @tfoote in this TODO?

@ahcorde
Addressed TODO in test_local_parameters
a842069 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from tfoote April 12, 2024 15:12
@ahcorde ahcorde self-assigned this Apr 12, 2024
tfoote
tfoote approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yes that's what it was intending.

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 15, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 08da25b into rolling Apr 15, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/todo_tully branch April 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @tfoote @fujitatomoya