New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review with Neville #2

Open

1 of 7 tasks

jmp1985 opened this issue Nov 22, 2021 · 0 comments

Collaborator

jmp1985 commented Nov 22, 2021 •

edited

Loading

Rename exported python functions from corr -> correct and recon -> reconstruct
Revisit command line functions with lots of kwargs
Maybe split kwargs into three dicts for abberations, micrscope params and plot params etc
Tidyup and comment MP stuff
Add error messages to asserts
Make angle input more flexible (i.e. maybe not metadata or regular steps)
Document C++ functions and classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment