Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RX Error Handler does not handle stack correctly #4

Closed
roscopeco opened this issue Sep 1, 2019 · 1 comment
Closed

RX Error Handler does not handle stack correctly #4

roscopeco opened this issue Sep 1, 2019 · 1 comment
Labels
invalid This doesn't seem right
Projects
Firmware Release 1

Comments

@roscopeco
Copy link
Collaborator

In the RX_ERROR_HANDLER: routine (in /firmware/rosco_m68k_v1/base_servers/serial_isr.S), the arguments passed to the C function handleRxError are not correctly cleaned up (required since -mrtd is not used in this codebase). This will cause the registers to be 'restored' to incorrect value and probably lead to a crash.

Need to look in to the GCC M68K ABI to see how these (byte-sized) arguments should be properly passed (suspect as a uint32) and then make sure they're cleaned up properly after the function call.
@roscopeco roscopeco added the bug Something isn't working label Sep 1, 2019
@roscopeco roscopeco added this to To do in Firmware Release 1 Mar 1, 2020
@roscopeco roscopeco mentioned this issue May 14, 2020
Closed
roscopeco added a commit that referenced this issue May 25, 2020
@roscopeco
# This is a combination of 9 commits.
29bf9f6 
# This is the 1st commit message:

First cut SPI and SD libs|

# This is the commit message #2:

First steps reading FAT filesystem

# This is the commit message #3:

Additions and bugfixes

# This is the commit message #4:

Add FAT support

# This is the commit message #5:

Major speed and size improvements

# This is the commit message #6:

First cut working SD in ROM

# This is the commit message #7:

First cut working SD in ROM

# This is the commit message #8:

Make build automagical

# This is the commit message #9:

Remove ROMs from VC and ignore them
@roscopeco roscopeco added invalid This doesn't seem right and removed bug Something isn't working labels May 27, 2020
@roscopeco
Copy link
Collaborator Author

Obsolete, won't do.

Firmware Release 1 automation moved this from To do to Done May 27, 2020
XarkLabs pushed a commit that referenced this issue Oct 6, 2021
easy68k-demo fixes, but trap15 #4 still broken
99ba490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
No open projects
Firmware Release 1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roscopeco