Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(ibl): update highlights for indent-blanklines #210

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

rgruyters
Copy link
Contributor

@rgruyters rgruyters commented Jan 12, 2024

Use new (shortend) syntax for indent-blankline. (ibl)

@rgruyters rgruyters changed the title feat(plugins): add support for ident-blankline style(ibl): update highlights for indent-blanklines Jan 12, 2024
@rgruyters
Copy link
Contributor Author

Do we want to set coloring for IblWhitespace?

@mvllow
Copy link
Member

mvllow commented Jan 12, 2024

I think we should keep the old highlights around for backwards compatibility. As far as IblWhitespace, what is it set to by default? We may need to also set IblWhitespace under our transparency highlights to remove the background as well.

- revert old highlights for legacy usage
- add `IblWhitespace` when highlighting white spaces
- add ibl highlights when using transparency
@rgruyters
Copy link
Contributor Author

I have updated the PR and revert the old highlights, added the IblWhitespace and added ibl highlights to the transparency section.

@mvllow mvllow merged commit 75dd31f into rose-pine:main Jan 13, 2024
@mvllow
Copy link
Member

mvllow commented Jan 13, 2024

Thank you for the updated highlights :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants