Implemented rarity config #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves rosebudmods#17 In doing this, I also discovered bugs with the Slime coloring. Slimes seem to ignore rarity, but I don't believe it's a fault of the rarity code. They also sometimes change colour upon touching the ground for the first time after being spawned. I think there's something else happening that's overriding their colours.
ix0rai
requested changes
Oct 7, 2023
| ((AllayVariantProvider) allay).setVariant(RainglowColour.get(colour)); | ||
| cir.setReturnValue(new AllayEntityData(RainglowColour.get(colour))); | ||
| ((AllayVariantProvider) allay).setVariant(this.random.nextInt(100) >= Rainglow.CONFIG.getRarity() ? RainglowColour.BLUE : RainglowColour.get(colour)); | ||
| cir.setReturnValue(new AllayEntityData(this.random.nextInt(100) >= Rainglow.CONFIG.getRarity() ? RainglowColour.BLUE : RainglowColour.get(colour))); |
There was a problem hiding this comment.
could you abstract this into a method?
There was a problem hiding this comment.
Sure thing! I'll get that done real fast!
|
No worries! If you want, I can also look into the slime colour issues and create a PR for that if I solve it! |
|
that would be fantastic! |
ix0rai
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #17
In doing this, I also discovered bugs with the Slime coloring. Slimes seem to ignore rarity, but I don't believe it's a fault of the rarity code. They also sometimes change colour upon touching the ground for the first time after being spawned. I think there's something else happening that's overriding their colours.