Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Ascend and Descend #254

Closed
roseduan opened this issue Aug 9, 2023 · 2 comments
Closed

add Ascend and Descend #254

roseduan opened this issue Aug 9, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@roseduan
Copy link
Collaborator

roseduan commented Aug 9, 2023

I use the btree as the index, so the previous iterator is removed.

And the btree has some similar functions to do the same thing, we can add it to the outside callers.

In this release we can add two common functions:

Ascend
Descend
@roseduan roseduan added the good first issue Good for newcomers label Aug 9, 2023
@weijiew
Copy link
Contributor

weijiew commented Aug 12, 2023

I've implemented the task and written unit tests for it. Additionally, I've provided unit tests for other APIs of the btree as well.Could you please review the PR and let me know if there are any issues? Is it ready to be merged?

@roseduan
Copy link
Collaborator Author

I've implemented the task and written unit tests for it. Additionally, I've provided unit tests for other APIs of the btree as well.Could you please review the PR and let me know if there are any issues? Is it ready to be merged?

There are some comments, thanks

@Jeremy-Run Jeremy-Run mentioned this issue Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roseduan @weijiew