add btree Ascend、Descend method and unitest. #257
Conversation
index/btree.go
Outdated
| @@ -64,3 +64,23 @@ func (mt *MemoryBTree) Delete(key []byte) (*wal.ChunkPosition, bool) { | |||
| func (mt *MemoryBTree) Size() int { | |||
| return mt.tree.Len() | |||
| } | |||
|
|
|||
| // Ascend calls f for each item in the tree in ascending order. If f returns false, iteration stops. | |||
There was a problem hiding this comment.
f -> handleFunc/handleFn maybe more clear?
The Caller can not use this function directly. We should add a function in db.go to get the value according to the position.
There was a problem hiding this comment.
Based on your suggestion, I have made further modifications to the code. Could you please review it to see if it meets your expectations? If not, please point out any issues, and I will make further adjustments. Due to my daytime commitments for company projects, I can only work on the open-source project during the evenings. I apologize for any delay in responding.
There was a problem hiding this comment.
it`s so kind of you to tell me this, I also maintain the project in my spare time, so just feel free to contribute.
There was a problem hiding this comment.
Thank you very much for the project you've written, which has enabled me to further study the Bitcask model.
db.go
Outdated
| @@ -265,6 +265,30 @@ func (db *DB) Watch() (chan *Event, error) { | |||
| return db.watchCh, nil | |||
| } | |||
|
|
|||
| // Ascend calls handleFn for each item in the tree in ascending order. | |||
There was a problem hiding this comment.
each item in the tree -> each key/value pair in the db
db.go
Outdated
| @@ -265,6 +265,30 @@ func (db *DB) Watch() (chan *Event, error) { | |||
| return db.watchCh, nil | |||
| } | |||
|
|
|||
| // Ascend calls handleFn for each item in the tree in ascending order. | |||
| func (db *DB) Ascend(handleFn func(k []byte, v []byte) bool) error { | |||
| db.index.Ascend(func(key []byte, pos *wal.ChunkPosition) bool { | |||
There was a problem hiding this comment.
-
we can let the caller handle the error, so the handleFn should be
func(k []byte, v []byte) (bool, error), and the Ascend has no return value. -
We must hold the read lock during the iteration.
db.mu.RLock
There was a problem hiding this comment.
Thank you for your guidance. I have made additional modifications. Could you please review it once more and let me know if there are any further changes needed?
|
Thanks |
No description provided.