Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock in merge.go #279

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

LEAVING-7
Copy link
Contributor

rosedb/merge.go

Lines 88 to 92 in d392613

// rotate the write-ahead log, create a new active segment file.
// so all the older segment files will be merged.
if err := db.dataFiles.OpenNewActiveSegment(); err != nil {
return err
}

It seems that the lock isn't released when the OpenNewActiveSegment function returns an error

@roseduan
Copy link
Collaborator

thanks

@roseduan roseduan merged commit cdb06c8 into rosedblabs:main Aug 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants