Skip to content

Commit

Permalink
added a comment
Browse files Browse the repository at this point in the history
  • Loading branch information
rosell-dk committed Nov 10, 2020
1 parent 4fcc9b5 commit 187a578
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions src/Convert/Converters/GraphicsMagick.php
Expand Up @@ -97,10 +97,18 @@ private function createCommandLineOptions()
{
$commandArguments = [];

// Unlike imagick binary, it seems gmagick binary uses a fixed
// quality (75) when quality is omitted
/*
if ($this->isQualityDetectionRequiredButFailing()) {
// Unlike imagick binary, it seems gmagick binary uses a fixed
// quality (75) when quality is omitted
// So we cannot simply omit in order to get same quality as source.
// But perhaps there is another way?
// Check out #91 - it is perhaps as easy as this: "-define jpeg:preserve-settings"
}
*/
$commandArguments[] = '-quality ' . escapeshellarg($this->getCalculatedQuality());


// encoding
if ($this->options['encoding'] == 'lossless') {
// Btw:
Expand Down

0 comments on commit 187a578

Please sign in to comment.