Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

231 improvements for use in flood modelling #251

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

231 improvements for use in flood modelling #251

wants to merge 21 commits into from

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Jun 10, 2024 •
edited
Loading

Changes:

  • formatting of dumped JSON instructions
  • added source to waterways stage - currently only OSM supported.
  • support saving geotiffs as well as netCDF files
  • Make robust to adding a river outside the catchment by simply ignore this river
  • update test(s) to save GeoTiffs,

Tick-list:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings (saving geotiffs, osm source default)
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson rosepearson linked an issue Jun 10, 2024 that may be closed by this pull request
Improvements for use in flood modelling #231
Open
4 tasks
github-actions and others added 19 commits June 10, 2024 09:23
fixup: Format Python code with Black
1fd1362
@rosepearson
commit prior to pull of autoblack corrections. Half made changes to s…
f7965c5 
…upport geotiff outputs
@rosepearson
Merge branch '231-improvements-for-use-in-flood-modelling' of github.…
057f0d6 
…com:rosepearson/GeoFabrics into 231-improvements-for-use-in-flood-modelling
@rosepearson
Added support for saving geotifs in addition to netCDF files.
a531849
@rosepearson
ensure all default values used are written to the instructions and ou…
520b83b 
…tputs in the dumped instruction file output.
@rosepearson
Added more information to history meta data, update history in furthe…
879d0d4 
…r runs, update roughness outputs with roughness specific metadata
@rosepearson
updated some spelling mistakes - logging/outputs
52b84a3
@rosepearson
Update setting attributes
0a7577c
@rosepearson
split out the LiDAR rasterisation from the coarse DEM regridding. Tes…
0a84b43 
…t then add a processor step for patching in a raster.
fixup: Format Python code with Black
97fe7b0
@rosepearson
Merge branch 'main' into 231-improvements-for-use-in-flood-modelling
b647f2a
@rosepearson
reduced LFS requirements per test run.
2e89d89
@rosepearson
Update tests actions to hopefully cache better
932dd62
@rosepearson
Another fix to GH actions tests - hopefully now properly caching acro…
4f5094b 
…ss OS
@rosepearson
fixed TB
34f31a9
@rosepearson
extend back to other Python versions
cf92f2d
@rosepearson
Add try catch to hopefully make robust to failing windows tests due t…
08cb1f2 
…o intermittent premissions erors
fixup: Format Python code with Black
132279d
@rosepearson
Added some more try catches to try make the windows tests more robust
4f0ec02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements for use in flood modelling
1 participant
@rosepearson