Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility functions don't return the ad #18

Closed
alonsovb opened this issue Jul 22, 2021 · 0 comments · Fixed by #24
Closed

Utility functions don't return the ad #18

alonsovb opened this issue Jul 22, 2021 · 0 comments · Fixed by #24

Comments

@alonsovb
Copy link

When calling the is_even or is_odd functions, the return value doesn't include the ad and I need it.

The typings file has the str ad definition, so why not return it?
spookyahell added a commit to spookyahell/PyIsEven that referenced this issue Aug 4, 2021
@spookyahell
Fixing tests & adding ability to view the advertisement (closes rosin…
c057d01 
…eygp#18)

The -10 assertException-Test didn't work previously
because it was implemented wrong
ever since implementation of the fallback method
spookyahell added a commit to spookyahell/PyIsEven that referenced this issue Aug 4, 2021
@spookyahell
Fixing tests & adding ability to view the advertisement
c947734 
(closes rosineygp#18)
See pull request for a screenshot of how many tries it really took to pass all tests
@rosineygp rosineygp linked a pull request Aug 6, 2021 that will close this issue
Spookyahell/master #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spookyahell/master rosineygp/PyIsEven
1 participant
@alonsovb