Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change version to MatchingBrowser and improve Edge support. #99

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Change version to MatchingBrowser and improve Edge support. #99

merged 3 commits into from
Sep 21, 2020

Conversation

anebot
Copy link
Contributor

@anebot anebot commented Sep 21, 2020

  • Change to use the current installed version of the browser instead of latest.
  • Improve Edge support by implementing GetMatchingBrowserVersion() and others.

Do the proposal in issue #97

kmspain and others added 3 commits September 21, 2020 18:25
@kmspain
Use the current version of the browser instead of the lastest, and im…
b3bf135 
…prove Edge support

- Change latest by MatchingBrowser in SetUpDriver call.
- Implement GetMatchingBrowserVersion call in EdgeConfig.
@rosolko
Update code. Fix tests.
43cf099
@rosolko
Update code. Fix tests
249adff
@rosolko
Copy link
Owner

rosolko commented Sep 21, 2020

Using of MatchingBrowser broke every other configs with not implemented GetMatchingBrowserVersion method

@rosolko rosolko merged commit 895622d into rosolko:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anebot @rosolko @kmspain