Add support for setting fan direction #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denismilanovic
changed the title
postlund
requested changes
Apr 1, 2021
|
Right, not sure which version of python that adds support for that. I guess we should go with |
|
Just updated the type to 'str | None' and added the future annotation. I figure it's better to match the signature used in core's fan component. |
|
Hi @postlund , just wondering whether anything else is needed on this one. I think it should be good to go at this stage. |
|
This can be abandoned once #542 is merged in instead. |
|
Abandoning since #542 is now merged and supports this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recently purchased Arlec 130cm White 4 Blade Grid Connect Smart DC Ceiling Fan runs great on LocalTuya. Both the fan and the HA fan component support changing the direction that the fan spins, and this simple change in LocalTuya has allowed me to control the fan direction in HA.