Attempt to solve inconsistent results when using genmypy cmake hooks in catkin workspace

[mikaelarguedas]

Hey there, thanks for the rospypi effort in general!

I attempted to use this in my ROS workspaces but had very inconsistent results.
I first thought that it was because the generation of the module files were dependant on the message/services pyi files being generated. While it helped a bit I still couldn't have reproducible builds.
Looking a little bit into it, it looks like the generation of the init.pyi files is dependant on already having a proper init.py file fully generated for the module. Is that a correct assumption ?

If so by using the changes in this PR I succeeded to have reproducible and more complete init.pyi files.
The PR basically introduced a dependency between genpy finishing generating message and module files for the genmypy file generation to kick in.

How I tested this:

• Made a workspace with the common_msgs repo
• 5 times:
  • Ran catkin_make_isolated
  • Looked at the number of lines of the generated pyi files

Using current master:

$ cat `find -name *.pyi` | wc -l
3747
$ cat `find -name *.pyi` | wc -l
3749
$ cat `find -name *.pyi` | wc -l
3762
$ cat `find -name *.pyi` | wc -l
3751
$ cat `find -name *.pyi` | wc -l
3736

Using this PR:

$ cat `find -name *.pyi` | wc -l
3765
$ cat `find -name *.pyi` | wc -l
3765
$ cat `find -name *.pyi` | wc -l
3765
$ cat `find -name *.pyi` | wc -l
3765
$ cat `find -name *.pyi` | wc -l
3765

[bonprosoft]

I'm so sorry for my late response!!!

Thank you for your wonderful contribution, I'm really appreciated!
I confirmed that your patch works perfectly.
LGTM!

it looks like the generation of the init.pyi files is dependant on already having a proper init.py file fully generated for the module. Is that a correct assumption ?

I also looked into this problem and I am sure that your assumption is correct!

[bonprosoft]

The CI error is totally unrelated to this PR. I will fix the issue, so please wait for a while 🙇‍♂️

[bonprosoft]

I have fixed the issue at #46, so could you merge the latest master branch into your PR or rebase this branch from the master branch? Thank you!

[mikaelarguedas]

I have fixed the issue at #46, so could you merge the latest master branch into your PR or rebase this branch from the master branch? Thank you!

Done 👍

[bonprosoft]

Looks great! Thank you for your contribution!

[mikaelarguedas]

Thanks!

Do you think this can be released in noetic in the near future🙏 ?