New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 50,000 limit to 100,000,000 as per advice #13
base: master
Are you sure you want to change the base?
Conversation
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this has been included in the diff. Nothings changed in this line.
This may actually be incorrect. Looking again now and the page mentions container limits. There's a post here: https://community.rackspace.com/products/f/25/t/597 100 million apparently |
Closing PR as it's incorrect. |
@rossj this has been reopened now and the limit has been changed to 100,000,000 (One hundred million) objects per container. |
@rogerthomas84 Thanks for the PR. I've seen a lot of different size recommendations floating around for different use cases. It used to be that the rate limiting of 100 reqs / sec started only at 50,000 files, and went to 4 / sec above 5 million. This does seem to no longer be the case based on the docs. How about making this a user option that can be overridden? |
@rossj I'll take a look at implementing that, I'm looking at some new functionality for it so I'll try to build that in. For now, feel free to close or merge this and I'll raise a new one for config changes (there will be a few). |
@rossj - The 50,000 limit is incorrect. The limit is actually 100,000,000 (soft limit) as per documentation here:
https://community.rackspace.com/products/f/25/t/597
Great little library though, thank you 馃憤