Conversation
'Fix bad quotes...' i stg |
Will come back to this... somehow I've fucked all your tests too |
FINALLY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution. I just have a few small comments. But otherwise I am happy with this.
Co-authored-by: Ross MacArthur <ross@macarthur.io>
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 791 809 +18
=========================================
+ Hits 791 809 +18
Continue to review full report at Codecov.
|
.idea/.gitignore
Outdated
@@ -0,0 +1,8 @@ | |||
# Default ignored files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these files in /.idea
, maybe add /.idea
to .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah god didn't even notice. Yeah.
Nice work, thanks for the contribution :) |
A field for the python stdlib's Decimal type.
This is to allow more precise handling of JSON encoded decimals... for things like monetary API's etc.