Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Added Decimal field... #128

Merged
merged 22 commits into from Feb 4, 2021
Merged

Added Decimal field... #128

merged 22 commits into from Feb 4, 2021

Conversation

vyrzdev
Copy link
Contributor

@vyrzdev vyrzdev commented Dec 1, 2020

A field for the python stdlib's Decimal type.

This is to allow more precise handling of JSON encoded decimals... for things like monetary API's etc.

@vyrzdev
Copy link
Contributor Author

vyrzdev commented Dec 1, 2020

'Fix bad quotes...' i stg

@vyrzdev
Copy link
Contributor Author

vyrzdev commented Dec 1, 2020

Will come back to this... somehow I've fucked all your tests too

@vyrzdev
Copy link
Contributor Author

vyrzdev commented Dec 4, 2020

FINALLY

Copy link
Owner

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your contribution. I just have a few small comments. But otherwise I am happy with this.

src/serde/fields.py Outdated Show resolved Hide resolved
src/serde/fields.py Outdated Show resolved Hide resolved
Co-authored-by: Ross MacArthur <ross@macarthur.io>
@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #128 (920aa3d) into master (675e85d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          791       809   +18     
=========================================
+ Hits           791       809   +18     
Impacted Files Coverage Δ
src/serde/fields.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675e85d...920aa3d. Read the comment docs.

.idea/.gitignore Outdated
@@ -0,0 +1,8 @@
# Default ignored files
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these files in /.idea, maybe add /.idea to .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah god didn't even notice. Yeah.

@rossmacarthur rossmacarthur merged commit 304884b into rossmacarthur:master Feb 4, 2021
@rossmacarthur
Copy link
Owner

Nice work, thanks for the contribution :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants