Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

General internal enhancements #5

Merged
merged 2 commits into from Nov 8, 2018
Merged

Conversation

rossmacarthur
Copy link
Owner

@rossmacarthur rossmacarthur commented Nov 8, 2018

  • Private API attributes and functions now all start with a single underscore.
  • Models have a "_fields" attribute to access the Fields dictionary.
  • Missing keys when deserializing will now raise a DeserializationError
    instead of a ValidationError.
  • Update tests to assert the above.
  • Various docstring updates.

- Private API attributes and functions now all start with a single underscore.
- Models have a "_fields" attribute to access the Fields dictionary.
- Missing keys when deserializing will now raise a DeserializationError
instead of a ValidationError.
- Use default `Exception.__repr__` method.
- Various docstring updates.
@rossmacarthur rossmacarthur merged commit c167f86 into master Nov 8, 2018
@rossmacarthur rossmacarthur deleted the rm-internal-api-improv branch November 8, 2018 19:36
rossmacarthur added a commit that referenced this pull request Nov 8, 2018
- Private API attributes and functions now all start with a single underscore.
- Models have a "_fields" attribute to access the Fields dictionary.
- Model.from_json() method now also accepts a "strict" option.
- Missing keys when deserializing will now raise a DeserializationError
instead of a ValidationError.
- Update tests to assert the above.
- Various docstring updates.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant