Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Profile Optimisations #145

Merged
merged 2 commits into from Oct 24, 2022

Conversation

mkroli
Copy link
Contributor

@mkroli mkroli commented Jul 10, 2022

This contains settings for the release profile which decreases the binary size from ~12M to ~4M on my machine.

@rossmacarthur
Copy link
Owner

rossmacarthur commented Oct 13, 2022

Hi @mkroli, I don't think that binary size is necessarily the optimization that all users would benefit from. So with the exception of the strip flag I don't think we should change anything in the release profile. I am happy for an additional profile to be added that has these settings though, e.g. cargo install sheldon --profile compact. Alternatively, we could simply document the RUSTFLAGS that need to be set when running cargo install sheldon to accomplish this.

@rossmacarthur rossmacarthur merged commit 36b6cc9 into rossmacarthur:trunk Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants