Skip to content

Conditional sourcing of plugins using profiles#143

Merged
rossmacarthur merged 9 commits intorossmacarthur:trunkfrom
mkroli:trunk
Jul 11, 2022
Merged

Conditional sourcing of plugins using profiles#143
rossmacarthur merged 9 commits intorossmacarthur:trunkfrom
mkroli:trunk

Conversation

@mkroli
Copy link
Copy Markdown
Contributor

@mkroli mkroli commented Jul 1, 2022

This contributes to #119 although it uses a different approach.

Copy link
Copy Markdown
Owner

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing! I love this addition and I think it is a suitable solution for #119.

Some more general comments:

  • We should consider adding a command line option --profile to sheldon as well similar to --clone-dir
  • Could you add at least one config file test in src/config/file.rs
  • Could you add at least one test that tests the filtering logic, probably easiest to add as another test case to the integration tests in the tests/ directory.
  • Could you add some documentation for this field in docs/src/Configuration.md
  • You can regenerate the completions using the following
cargo run -- completions --shell bash > completions/sheldon.bash
cargo run -- completions --shell zsh > completions/sheldon.zsh
  • Don't worry about the clippy lints failing on GitHub Actions

@mkroli
Copy link
Copy Markdown
Contributor Author

mkroli commented Jul 9, 2022

Thanks for the detailed review. Can you please check my recent changes?

Copy link
Copy Markdown
Owner

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to run cargo run -p gen-readme since you modified the documentation.

mkroli and others added 4 commits July 10, 2022 14:39
Co-authored-by: Ross MacArthur <ross@macarthur.io>
Co-authored-by: Ross MacArthur <ross@macarthur.io>
@mkroli
Copy link
Copy Markdown
Contributor Author

mkroli commented Jul 10, 2022

Thanks once more! Worked on your suggestions.

@rossmacarthur
Copy link
Copy Markdown
Owner

rossmacarthur commented Jul 10, 2022

Hmmm build is failing I think my suggestions were not 100% correct code.

@mkroli
Copy link
Copy Markdown
Contributor Author

mkroli commented Jul 10, 2022

Didn't catch the compilation errors. Latest commit reverts some code but removes the unnecessary collect you mentioned.

@rossmacarthur rossmacarthur merged commit 4385f4b into rossmacarthur:trunk Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants