Conditional sourcing of plugins using profiles #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi, thanks for contributing! I love this addition and I think it is a suitable solution for #119.
Some more general comments:
- We should consider adding a command line option
--profileto sheldon as well similar to--clone-dir - Could you add at least one config file test in
src/config/file.rs - Could you add at least one test that tests the filtering logic, probably easiest to add as another test case to the integration tests in the
tests/directory. - Could you add some documentation for this field in
docs/src/Configuration.md - You can regenerate the completions using the following
cargo run -- completions --shell bash > completions/sheldon.bash
cargo run -- completions --shell zsh > completions/sheldon.zsh- Don't worry about the clippy lints failing on GitHub Actions
|
Thanks for the detailed review. Can you please check my recent changes? |
Co-authored-by: Ross MacArthur <ross@macarthur.io>
Co-authored-by: Ross MacArthur <ross@macarthur.io>
|
Thanks once more! Worked on your suggestions. |
|
Hmmm build is failing I think my suggestions were not 100% correct code. |
|
Didn't catch the compilation errors. Latest commit reverts some code but removes the unnecessary collect you mentioned. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #119 although it uses a different approach.