Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input is mutated #17

Closed
dwbutler opened this issue Nov 29, 2016 · 3 comments
Closed

Input is mutated #17

dwbutler opened this issue Nov 29, 2016 · 3 comments

Comments

@dwbutler
Copy link
Contributor

Input that is passed into the conjugator is mutated because of the use of concat. This causes unexpected errors if the same input is used later and expected to be the original value.

> verb = 'like'

> Verbs::Conjugator.conjugate(
  verb,
  tense:   :past,
  aspect:  :perfective
)
=> "liked"

> verb
=> "liked"
@rossmeissl
Copy link
Owner

@dwbutler — thanks for this. Are you interested in submitting a PR? Even just a failing test would be excellent if you don't have time for the fix.

@dwbutler
Copy link
Contributor Author

Sure, I can take a stab at it.

@dwbutler dwbutler mentioned this issue Nov 29, 2016
Merged
@rossmeissl
Copy link
Owner

Closing in favor of #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossmeissl @dwbutler