Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input immutability #18

Merged
merged 2 commits into from
Nov 29, 2016
Merged

Input immutability #18

merged 2 commits into from
Nov 29, 2016

Conversation

dwbutler
Copy link
Contributor

A start for fixing input immutability (#17).

Notes:

  • Added a failing test.
  • Added the test-unit gem because it was removed from the standard library in Ruby 2.2+.
  • Tried adding infinitive = infinitive.to_s.clone to Verbs::Conjugator.conjugate. This caused a lot of test failures. Apparently there is internal code that relies on mutating behavior.

@rossmeissl rossmeissl mentioned this pull request Nov 29, 2016
This prevents unintended mutation.
@rossmeissl rossmeissl merged commit a91cf8f into rossmeissl:master Nov 29, 2016
@rossmeissl
Copy link
Owner

Thanks @dwbutler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants