Add more single terminal consonants #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerixim
force-pushed
the
add-more-single-terminal-consonants
branch
from
1c31be9
to
1e53a5b
Compare
nerixim
changed the title
rossmeissl
reviewed
Dec 22, 2020
test/test_verbs.rb
Outdated
| @@ -398,4 +398,9 @@ def test_passive | |||
| Verbs::Conjugator.conjugate(:be, diathesis: :passive) | |||
| end | |||
| end | |||
|
|
|||
| def test_not_modifying_frozen_string | |||
| assert_equal 'is diying', Verbs::Conjugator.conjugate(:die, aspect: :progressive) | |||
There was a problem hiding this comment.
@nerixim can you please comment on this? diying is not correct unless I'm misunderstanding the test.
There was a problem hiding this comment.
Oops I forgot you couldn't conjugate die yet.
I'll change these examples with another verb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40 #49