Update Menu.save() method to pass *args and **kwargs argument. The curre... #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent implementation explicitly lists force_insert and force_update only. Considering the full list of kwargs save() expects includes 'using' and 'update_fields', this is problematic if these kwargs need to be specified when saving a new Menu object. For example, when create a new Menu with factory-boy, the user is presented with the following error: "TypeError: save() got an unexpected keyword argument 'using'". Since the current implementation uses the default values for force_insert and force_update anyway, simply passing *args and **kwargs is an acceptable way to fulfill the underlying API contract.
rossp
added a commit
that referenced
this pull request
Sep 1, 2013
Update Menu.save() method to pass *args and **kwargs argument. The curre...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nt
implementation explicitly lists force_insert and force_update only. Considering
the full list of kwargs save() expects includes 'using' and 'update_fields',
this is problematic if these kwargs need to be specified when saving a new Menu
object. For example, when create a new Menu with factory-boy, the user is
presented with the following error: "TypeError: save() got an unexpected
keyword argument 'using'". Since the current implementation uses the default
values for force_insert and force_update anyway, simply passing _args and
*_kwargs is an acceptable way to fulfill the underlying API contract.