Make color escape sequences conform to terminfo entry #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
img2xterm had been combining multiple 256color rendition changes in the same SGR sequence, e.g., `ESC [ 48;5;179; 38;5;100 m` to change both the background and foreground color. The xterm-256color terminfo entry requires (and mosh enforces) that these be in separate escapes. This commit makes the img2xterm output render correctly in mosh. Example: `echo -e "setab 179\nsetaf 100" | tput -S | od -c` generates `ESC [ 48;5;179 m ESC [ 38;5;100 m`. * Olivia5k/doge#48 * mobile-shell/mosh#519 * mobile-shell/mosh#110 (comment)
|
Looks good. Merging those sequences definitely isn't worth it if it causes incompatibility with mosh. Thanks for the patch. |
rossy
added a commit
that referenced
this pull request
May 12, 2014
Make color escape sequences conform to terminfo entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
img2xterm had been combining multiple 256color rendition changes in the
same SGR sequence, e.g.,
ESC [ 48;5;179; 38;5;100 mto change both thebackground and foreground color.
The xterm-256color terminfo entry requires (and mosh enforces) that
these be in separate escapes. This commit makes the img2xterm output
render correctly in mosh.
Example:
echo -e "setab 179\nsetaf 100" | tput -S | od -cgeneratesESC [ 48;5;179 m ESC [ 38;5;100 m.