Fail gracefully for threads that don't have messages #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I occasionally get email notifications of errors in `processThreads` that say `TypeError: Cannot read property "length" from null. (line 134, file "Code")`. I haven't been able to figure out what's causing this, and there's nothing in [the documentation](https://developers.google.com/apps-script/reference/gmail/gmail-thread#getMessages()) about why getMessages would return `null` for a thread, but it's still better not to crash the entire script when it _does_ happen, since that could delay/confuse the untickling of other threads.
|
Note to self, in case I want to investigate this in the future: I think I just reproduced it by replying to myself on a thread that already had a tickler label, causing it to move around between my archive and inbox while the script was running. |
|
Closing this since I haven't seen it with the new implementation from #6, but will re-open if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I occasionally get email notifications of errors in
processThreadsthat sayTypeError: Cannot read property "length" from null. (line 134, file "Code"). I haven't been able to figure out what's causing this, and there's nothing in the documentation about why getMessages would returnnullfor a thread, but it's still better not to crash the entire script when it does happen, since that could delay/confuse the untickling of other threads.(My personal script has a few extra lines of config, hence the slight mismatch in the line numbers.)