Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize MVP package for multi-service architecture #11

Merged
merged 1 commit into from Sep 20, 2022

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Sep 20, 2022

Scope of changes

Moves server package to ensign package and refactors top level packages to move to the ensign package so other services such as tenant and quarterdeck can be defined at the package level. Note: keeping the api and mimetype packages at the top level so they can be imported by client code.

Fixes SC-9453

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Just reorganization so should be able to sign off on this if the tests pass!

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • I understand the new package structure
  • The tests are passing

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #9453: Reorganize MVP package for multi-service architecture.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #11 (3bba2e2) into main (26beead) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files          12       12           
  Lines         701      701           
=======================================
  Hits          472      472           
  Misses        199      199           
  Partials       30       30           
Flag Coverage Δ
unittests 67.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ithub.com/rotationalio/ensign/pkg/server/events.go
...c/github.com/rotationalio/ensign/pkg/config/env.go
...ithub.com/rotationalio/ensign/pkg/config/config.go
...ithub.com/rotationalio/ensign/pkg/server/server.go
...ithub.com/rotationalio/ensign/pkg/server/status.go
...rc/github.com/rotationalio/ensign/pkg/rlid/rlid.go
...ub.com/rotationalio/ensign/pkg/server/o11y/o11y.go
...ithub.com/rotationalio/ensign/pkg/ensign/status.go 76.92% <0.00%> (ø)
...ub.com/rotationalio/ensign/pkg/ensign/rlid/rlid.go 95.23% <0.00%> (ø)
...ithub.com/rotationalio/ensign/pkg/ensign/events.go 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@daniellemaxwell daniellemaxwell merged commit 4b62f16 into main Sep 20, 2022
@daniellemaxwell daniellemaxwell deleted the sc-9453/reorganize branch September 20, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants