Detail and delete api key tenant handlers #116
Conversation
|
This pull request has been linked to Shortcut Story #10411: Implement APIKey Resource Detail/Delete Handlers. |
| Modified: key.Modified.Format(time.RFC3339Nano), | ||
| ID: key.ID.String(), | ||
| ClientID: key.ClientID, | ||
| Name: key.Name, |
There was a problem hiding this comment.
List is only supposed to return some of the fields (see the quarterdeck implementation) so I've updated the handler to reflect that.
|
|
||
| // Delete the API key using Quarterdeck | ||
| // TODO: Handle error status codes returned by Quarterdeck | ||
| if err = s.quarterdeck.APIKeyDelete(ctx, apiKeyID); err != nil { |
There was a problem hiding this comment.
Note that quarterdeck will actually return 404 if the API key is not in the user's organization (to prevent users deleting keys from other organizations). However, we should probably be handling the different error cases that get returned from Quarterdeck so I've added some TODOs in this file.
pkg/tenant/apikeys.go
Outdated
| return | ||
| } | ||
|
|
||
| c.JSON(http.StatusNoContent, nil) |
There was a problem hiding this comment.
Could this be replaced with c.Status(http.StatusNoContent) or does nil need to be returned here?
There was a problem hiding this comment.
Yes, thanks for catching this!
Scope of changes
This implements the detail and delete api key tenant handlers. These should be pretty straightforward given the pattern setup in SC-10407.
There was also a slight change to
ProjectAPIKeyListwhich should also be reviewed.Fixes SC-10411
Type of change
Acceptance criteria
The endpoint handlers make sense given the TODOs in the code.
Author checklist
Reviewer(s) checklist