Add Newly Registered User to SendGrid Marketing Contacts #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13177: Add newly registered user to SendGrid marketing list. |
daniellemaxwell
approved these changes
Jan 26, 2023
| @@ -62,6 +63,26 @@ func (s *Server) Register(c *gin.Context) { | |||
| // TODO: Send verification email to the provided email address | |||
| // TODO: Create tenant and other Tenant-specific resources for the user | |||
|
|
|||
| // Add to SendGrid Ensign Marketing list in go routine | |||
| // TODO: use worker queue to limit number of go routines for tasks like this | |||
| // TODO: test in live integration tests to make sure this works | |||
There was a problem hiding this comment.
Fingers crossed this will work without an issue!
Co-authored-by: Danielle <danielle@rotational.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
In the tenant Register() handler, I added functionality to add the user to the Ensign marketing list in SendGrid since this was already configured in Tenant. This will likely have to be refactored in the future, and there are some TODOs here, but this will get us through the MVP.
Fixes SC-13177
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Author checklist
Reviewer(s) checklist