Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ensign for developers page #129

Merged
merged 8 commits into from Jan 29, 2023
Merged

Add Ensign for developers page #129

merged 8 commits into from Jan 29, 2023

Conversation

pdeziel
Copy link
Contributor

@pdeziel pdeziel commented Jan 27, 2023

Scope of changes

This adds a page to the documentation with an end-to-end pub/sub example.

The example code is available here: https://github.com/rotationalio/ensign-examples/tree/main/go/tweets

Fixes SC-12537

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12537: Create E2E tutorial for Ensign MVP Developer user.

Copy link
Member

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pdeziel, fantastic work! I added in a little publicity blurb to the examples/_index.md, hope that's ok!

@rebeccabilbro rebeccabilbro merged commit 2fe870a into main Jan 29, 2023
@rebeccabilbro rebeccabilbro deleted the sc-12537 branch January 29, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants