Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 12459/create tenant #130

Merged
merged 13 commits into from Jan 31, 2023
Merged

Sc 12459/create tenant #130

merged 13 commits into from Jan 31, 2023

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Jan 27, 2023

Scope of changes

Adds SetupTenant view to the Beacon UI.

Fixes SC-12459

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Screenshot 2023-01-27 at 5 59 10 PM (2)
Screenshot 2023-01-27 at 5 59 14 PM (2)

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12459: Beacon FE : add Setup Tenant component view.


function SetupTenant() {
return (
<section className="bg-hexagon bg-contain">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Figma design includes the hexagons in the background, but they don't appear in Storybook. If the bg image should be removed, let me know.

environment.
</p>
<p className="mt-6">You can change settings later and upgrade at any time.</p>
<Button className="mt-32 h-14 w-44 rounded bg-danger-500 text-center text-xl font-bold text-white">Create</Button>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Customizing your tenant requires a paid plan. Upgrade now to set up a tenant specific to
your development and modeling needs.
</p>
<Button className="mt-16 h-14 w-48 rounded bg-danger-500 text-center text-xl font-bold text-white">Coming Soon</Button>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a class for the repeated button styles in the CSS file, but the styling didn't appear in Storybook so I added it back to the className here.

Copy link
Contributor

@masskoder masskoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellemaxwell daniellemaxwell merged commit 9560df0 into main Jan 31, 2023
@daniellemaxwell daniellemaxwell deleted the sc-12459/create-tenant branch January 31, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants