Authenticate Interceptor #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13307: Authentication Interceptor. |
pdeziel
approved these changes
Jan 31, 2023
|
|
||
| // ClaimsFrom returns the claims from the context if they exist or false if not. | ||
| func ClaimsFrom(ctx context.Context) (*tokens.Claims, bool) { | ||
| claims, ok := ctx.Value(KeyClaims).(*tokens.Claims) |
There was a problem hiding this comment.
Yes, it probably could. I wrote it this way to make it easier to put an if statement on the first block if further checking was necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds an
Authenticatorwhich creates unary and stream interceptors for ensuring that JWT tokens in the credentials are authenticated and adds the claims to the context of the request for access by handlers if necessary.Fixes SC-13307
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Author checklist
Reviewer(s) checklist