Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 12454 Beacon FE: add successfully account creation component #141

Merged
merged 2 commits into from Feb 1, 2023

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Jan 31, 2023

Scope of changes

Fixes SC-12454

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12454: Beacon FE: add successfully account creation component.

Copy link
Member

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elysee15 - I'm noticing that the word "successful" is misspelled in several places in this PR (there should only be one "l" at the end of the word). Can you please do a find and replace to ensure that the spelling is correct?

@elysee15 elysee15 force-pushed the sc-12454 branch 2 times, most recently from 5853de2 to 2b3c607 Compare January 31, 2023 21:29
Copy link
Contributor

@masskoder masskoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masskoder masskoder merged commit b15971b into main Feb 1, 2023
@masskoder masskoder deleted the sc-12454 branch February 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants