sc-12355 Beacon FE: add registration feature #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12355: Beacon FE: add registration feature with e2e test integration (cypress). |
elysee15
force-pushed
the
sc-12355
branch
15 times, most recently
from
f12bee6
to
d30459f
Compare
elysee15
force-pushed
the
sc-12355
branch
2 times, most recently
from
5945a4a
to
8e7f649
Compare
elysee15
force-pushed
the
sc-12355
branch
2 times, most recently
from
6413cbc
to
d1291d8
Compare
masskoder
reviewed
Feb 3, 2023
| @@ -2,21 +2,23 @@ import { AriaButton as Button } from '@rotational/beacon-core'; | |||
| import { memo } from 'react'; | |||
There was a problem hiding this comment.
@elysee15 this component is used by 2 other features components. would you mind moving it to the Components folder
elysee15
force-pushed
the
sc-12355
branch
7 times, most recently
from
d213c95
to
89a510c
Compare
| <div className="flex flex-col gap-4 px-4 py-8 text-sm sm:p-8 md:flex-row md:p-16 xl:text-base"> | ||
| <div className="space-y-4 rounded-md border border-[#1D65A6] bg-[#1D65A6] p-4 text-white sm:p-8 md:w-2/6"> | ||
| <h1 className="text-center font-bold"> | ||
| Building event-driven applications can be fast, convenient and even fast! |
There was a problem hiding this comment.
@elysee15 @masskoder just noticed a typo here - the text should be:
Building event-driven applications can be fast, convenient and even fun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Fixes SC-12355
Type of change
Acceptance criteria
https://app.shortcut.com/rotational/story/12355/beacon-fe-add-registration-feature-with-e2e-test-integration-cypress
Author checklist
Reviewer(s) checklist