New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sentry for Demo Error Tracking #15
Conversation
This pull request has been linked to Shortcut Story #9558: Add Sentry for Demo Error Tracking. |
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 60.26% 57.53% -2.73%
==========================================
Files 18 29 +11
Lines 916 1606 +690
==========================================
+ Hits 552 924 +372
- Misses 328 622 +294
- Partials 36 60 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
15d2db8
to
38add62
Compare
4d51709
to
a8ede2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following comments are related to the ensign/server.go file. To be honest, they may be a little nitpicky.
On line 113, the comment appears to have a typo where "...is metrics are enabled" is stated. I think using "...if metrics are enabled" may be clearer to readers.
On line 180, mainenance is declared as the variable name. Would it be clearer to readers if "maintenace" is used?
On line 191, the comment appears to have a typo where "endpoints" is spelled like "endpoings".
Everything else looked good to me.
I don't mind nitpicky/spelling/typo corrections at all! I'll go ahead and make those changes. One thing you can do if you see stuff like that is use the "suggestion" feature in GitHub; that allows us to make all these changes a bit quicker; happy to go over that this afternoon if you'd like. |
Going over the suggestion feature would be great! Thank you! |
Scope of changes
Sentry integration and Quarterdeck API testing code with @daniellemaxwell.
This PR adds a lot of monitoring and logging to Ensign for debugging and performance testing purposes. It does go beyond what the story asks of it, but it is essential for Ensign MVP development and understanding what is happening on the server. I've added notes to help the review process. See acceptance criteria below.
I've also implemented a Grafana dashboard for this PR:
It contains event monitoring, gRPC monitoring, and Go process monitoring.
Fixes SC-9558
Type of change
Acceptance criteria
I've added notes to help you in the review process; please resolve the notes when you've read them.
Files you can ignore:
containers/monitor/grafana/dashboards/ensign.json
: contains the grafana dashboard description; see screenshot above.go.mod
andgo.sum
: deps added were go-sentry and cors middleware for gin.pkg/utils/logger/grpc.go
: copy and paste from grpclog to reduce the logging verbosity from the serverAuthor checklist
Reviewer(s) checklist