New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose profiles #163
Conversation
This pull request has been linked to Shortcut Story #13536: Docker compose profiles. |
p) PLATFORM=$OPTARG | ||
P) PLATFORM=$OPTARG | ||
;; | ||
p) PROFILE=$OPTARG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there's a bit of arg collision - I'll welcome any naming suggestions to reduce confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, this is a bit tricky but I think the -P
and -p
the way you did it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me; thank you for adding this in for them!
p) PLATFORM=$OPTARG | ||
P) PLATFORM=$OPTARG | ||
;; | ||
p) PROFILE=$OPTARG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, this is a bit tricky but I think the -P
and -p
the way you did it is fine.
Scope of changes
This adds profile support to the docker compose, mostly to allow the frontend to build the backend and frontend separately to make development easier.
Currently supported profiles:
backend
ui
monitoring
all
Fixes SC-13536
Type of change
Acceptance criteria
The
build.sh
command should now support docker compose profiles with the-p
option.Author checklist
Reviewer(s) checklist