Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose profiles #163

Merged
merged 2 commits into from Feb 6, 2023
Merged

Docker compose profiles #163

merged 2 commits into from Feb 6, 2023

Conversation

pdeziel
Copy link
Contributor

@pdeziel pdeziel commented Feb 3, 2023

Scope of changes

This adds profile support to the docker compose, mostly to allow the frontend to build the backend and frontend separately to make development easier.

Currently supported profiles:

backend
ui
monitoring
all

Fixes SC-13536

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

The build.sh command should now support docker compose profiles with the -p option.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?
  • Any profiles we want to change/add while we're here?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #13536: Docker compose profiles.

p) PLATFORM=$OPTARG
P) PLATFORM=$OPTARG
;;
p) PROFILE=$OPTARG
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there's a bit of arg collision - I'll welcome any naming suggestions to reduce confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, this is a bit tricky but I think the -P and -p the way you did it is fine.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; thank you for adding this in for them!

p) PLATFORM=$OPTARG
P) PLATFORM=$OPTARG
;;
p) PROFILE=$OPTARG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, this is a bit tricky but I think the -P and -p the way you did it is fine.

@bbengfort bbengfort merged commit 256221b into main Feb 6, 2023
@bbengfort bbengfort deleted the sc-13536 branch February 6, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants