Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Sentry and Status Tests #17

Merged
merged 3 commits into from Sep 26, 2022
Merged

Finalize Sentry and Status Tests #17

merged 3 commits into from Sep 26, 2022

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Sep 26, 2022

Scope of changes

Code from our 馃崘 today! I finalized all the last TODO items that we discussed.

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #17 (4144faa) into main (ad7f8e2) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   55.76%   56.09%   +0.32%     
==========================================
  Files          29       29              
  Lines        1664     1706      +42     
==========================================
+ Hits          928      957      +29     
- Misses        677      686       +9     
- Partials       59       63       +4     
Flag Coverage 螖
unittests 56.09% <酶> (+0.32%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...rotationalio/ensign/pkg/quarterdeck/quarterdeck.go 80.00% <0.00%> (-4.62%) 猬囷笍
...com/rotationalio/ensign/pkg/utils/sentry/config.go 28.00% <0.00%> (-1.17%) 猬囷笍
...tationalio/ensign/pkg/quarterdeck/config/config.go 74.28% <0.00%> (-0.72%) 猬囷笍
...om/rotationalio/ensign/pkg/ensign/config/config.go 42.18% <0.00%> (+2.84%) 猬嗭笍
....com/rotationalio/ensign/pkg/quarterdeck/status.go 100.00% <0.00%> (+10.00%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/ensign/config/config_test.go Show resolved Hide resolved
pkg/quarterdeck/config/config_test.go Show resolved Hide resolved
@bbengfort bbengfort merged commit 9caf46a into main Sep 26, 2022
@bbengfort bbengfort deleted the api-pear branch September 26, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants